-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Site editor - Duplicated name colors when adding/deleting in custom palette #39945
Comments
I imagine that this happens because we generate the name of the new color by adding one the number of rows. A good solution that avoids repeating the name of the color, no matter how they are arranged on the list, would be to do something like Figma does with pages: sort all the pages that are labeled "Page X" (where X is a number), and then create a new page with the subsequent number. Screen.Recording.2022-03-31.at.16.23.06.mov |
I threw up something over at #40837 It tries to replicate Photoshop's layout behaviour: |
Description
While creating a custom color palette in the site editor, there's a case where deleting the first colors would cause a bug where new colors created will keep the previous name causing duplicates.
Then when using these colors that have the same name there's a bug where the color you select is not the one you see.
Step-by-step reproduction instructions
Screenshots, screen recording, code snippet
ColorBug.mov
Environment info
12.8.0
98.0.4758
Please confirm that you have searched existing issues in the repo.
Yes
Please confirm that you have tested with all plugins deactivated except Gutenberg.
Yes
The text was updated successfully, but these errors were encountered: