Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Explore using CSS Grid in Interface Skeleton #33776

Closed
talldan opened this issue Jul 30, 2021 · 1 comment
Closed

Explore using CSS Grid in Interface Skeleton #33776

talldan opened this issue Jul 30, 2021 · 1 comment
Labels
CSS Styling Related to editor and front end styles, CSS-specific issues. [Package] Interface /packages/interface [Type] Enhancement A suggestion for improvement.

Comments

@talldan
Copy link
Contributor

talldan commented Jul 30, 2021

What problem does this address?

Currently, all WordPress editors (apart from customize widgets) use the InterfaceSkeleton component from the interface package for the general layout of the editor:
https://github.com/WordPress/gutenberg/tree/trunk/packages/interface/src/components/interface-skeleton

It's a very simple React component that defines various areas for the layout (header, sidebar, notices, content, footer etc.). In terms of CSS, the layout is currently achieved using Flexbox, which has been prone to some bugs in the past.

It seems like a very good fit for CSS Grid, and now that IE11 is no longer supported, this could be explored. CSS grid could also potentially open up the possibility of more easily defined alternative editor layouts (the navigation editor has explored this in the past).
@talldan talldan added [Package] Interface /packages/interface CSS Styling Related to editor and front end styles, CSS-specific issues. labels Jul 30, 2021
@skorasaurus
Copy link
Member

skorasaurus commented Jul 30, 2021 •
edited
Loading

ref/further background #16271

@jordesign jordesign added the [Type] Enhancement A suggestion for improvement. label Aug 17, 2023
@talldan talldan closed this as not planned Won't fix, can't repro, duplicate, stale Jul 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
CSS Styling Related to editor and front end styles, CSS-specific issues. [Package] Interface /packages/interface [Type] Enhancement A suggestion for improvement.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@talldan @skorasaurus @jordesign