-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Framework: Improve how post revisions are handled #3258
Comments
Marking this high priority for merge proposal. |
This ticket was mentioned in Slack in #core-editor by jeffpaul. View the logs. |
@danielbachhuber, I don't think it #6257 is directly related to this issue. We had this issue where all revisions were loaded and cached inside HTML output just to read the url of the last revision and the total count of revisions. I added a hook which adds those 2 values to the post object which didn't seem ideal, but solved all performance issues. See https://github.com/WordPress/gutenberg/pull/3233/files#diff-9dfc2b70ad1c71918441461179054b0b in particular. This issue exists to find an alternative solution which would be included also in WP Core. |
I've opened a core ticket for this: https://core.trac.wordpress.org/ticket/44321 Whatever conclusion we identify there, we can apply here in the interim. |
Issue Overview
When fixing #3167 with #3233 we opened a discussion on how to handle post revisions in the long run:
Let's discuss here how we can improve the current solution - https://github.com/WordPress/gutenberg/pull/3233/files#diff-9dfc2b70ad1c71918441461179054b0bR386. REST API endpoint for post data is extended to serve also information about revisions. The downside of this approach is that it is now added to every REST API call that fetches post data.
The text was updated successfully, but these errors were encountered: