List content lost when switching list type

[draganescu]

Description

List content lost when switching list type.

Step-by-step reproduction instructions

In any block editor:

1. add a list block
2. add some list items
3. from the block toolbar convert from unorererd to ordered
4. list content is lost

Expected behaviour

List content to not be lost

Actual behaviour

List content is lost

Screenshots or screen recording (optional)

list-content-lost.mp4

WordPress information

• WordPress version: 5.7.2
• Gutenberg version: Trunk
• Are all plugins except Gutenberg deactivated? Yes
• Are you using a default theme (e.g. Twenty Twenty-One)? Yes

Device information

• Device: Desktop
• Operating system: OSX
• Browser: Safari

[paaljoachim]

I just tested with WP 5.8 and switching between list types removes the list content.

[torounit]

2021-06-03.13.56.21.mov

Values are saved. Indenting will apply the changes.

Gutenberg version: Trunk

[torounit]

The new value is passed to <RichText>, but it is not displayed correctly.

[torounit]

gutenberg/packages/rich-text/src/component/index.js

Lines 201 to 204 in 79cb3eb

	useRefEffect( () => {
	applyFromProps();
	didMount.current = true;
	}, [ placeholder, ...__unstableDependencies ] ),

If the applyFromProps on this line is executed, the edited text will be returned.

[torounit]

gutenberg/packages/rich-text/src/component/index.js

Line 148 in 79cb3eb

setRecordFromProps();

If you comment out this line, it will be displayed correctly.

[ellatrix]

I see this is also happening with the heading block. We have a test that was supposed to guard against problems with placing the node type, but it didn't test adding content:

gutenberg/packages/e2e-tests/specs/editor/various/rich-text.test.js

Line 19 in 979fb04

it( 'should handle change in tag name gracefully', async () => {

.

[torounit]

@ellatrix Happening with the heading block too.

2021-06-04.12.57.32.mov