-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Post Comments Form: Implementation Notes #24221
Comments
@Copons just checking what still needs doing design-wise here as this is a little older issue. I currently see: Which is very 'lacking' so my belief is that showing an actual 'form' makes a lot more sense. But, just checking that is still the intention here and if so I can mock that up to finally unblock this little task. |
I always pictured that this would be a block with inner blocks so that the field names, labels and position could be changed or removed. |
The block actually shows the form in the editor now. so I'm closing this issue. |
The Post Comments Form block is currently implemented to be rendered by
comment_form()
on the frontend (which can be fairly complex, containing several different labels, messages, and the form itself in different versions for logged in and out users.In the editor, it is just a placeholder.
We need to match what is editable in the editor with the output produced by the frontend, by replicating the logic of the
comment_form()
function (see also #22724 for a breakdown of other possible functions affecting the comment form).All its parameters and the comment form filters (
comment_form_default_fields
,comment_form_field_{$name}
) should be taken into consideration.Props to @ockham for #24101, which inspired this issue.
The text was updated successfully, but these errors were encountered: