Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Post Comments Form: Implementation Notes #24221

Closed
Copons opened this issue Jul 27, 2020 · 3 comments
Closed

Post Comments Form: Implementation Notes #24221

Copons opened this issue Jul 27, 2020 · 3 comments
Labels
[Block] Post Comments Form Affects the Comments Form Block [Feature] Blocks Overall functionality of blocks [Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") Needs Design Needs design efforts.

Comments

@Copons
Copy link
Contributor

Copons commented Jul 27, 2020

The Post Comments Form block is currently implemented to be rendered by comment_form() on the frontend (which can be fairly complex, containing several different labels, messages, and the form itself in different versions for logged in and out users.

In the editor, it is just a placeholder.

We need to match what is editable in the editor with the output produced by the frontend, by replicating the logic of the comment_form() function (see also #22724 for a breakdown of other possible functions affecting the comment form).
All its parameters and the comment form filters (comment_form_default_fields, comment_form_field_{$name}) should be taken into consideration.

Props to @ockham for #24101, which inspired this issue.

@Copons Copons added [Feature] Blocks Overall functionality of blocks Needs Design Needs design efforts. [Feature] Full Site Editing [Block] Post Comments Form Affects the Comments Form Block labels Jul 27, 2020
@karmatosed
Copy link
Member

@Copons just checking what still needs doing design-wise here as this is a little older issue. I currently see:

2021-09-10 at 17 57

Which is very 'lacking' so my belief is that showing an actual 'form' makes a lot more sense. But, just checking that is still the intention here and if so I can mock that up to finally unblock this little task.

@carolinan
Copy link
Contributor

I always pictured that this would be a block with inner blocks so that the field names, labels and position could be changed or removed.
But that would mean no longer relying on comment_form() and its filters.

@annezazu annezazu added [Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") and removed [Feature] Full Site Editing labels Jul 24, 2023
@youknowriad
Copy link
Contributor

The block actually shows the form in the editor now. so I'm closing this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Post Comments Form Affects the Comments Form Block [Feature] Blocks Overall functionality of blocks [Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") Needs Design Needs design efforts.
Projects
None yet
Development

No branches or pull requests

5 participants