Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev Notes for WP 5.5 #23669

Closed
12 tasks done
ellatrix opened this issue Jul 3, 2020 · 28 comments
Closed
12 tasks done

Dev Notes for WP 5.5 #23669

ellatrix opened this issue Jul 3, 2020 · 28 comments
Labels
[Type] Tracking Issue Tactical breakdown of efforts across the codebase and/or tied to Overview issues.

Comments

@ellatrix
Copy link
Member

ellatrix commented Jul 3, 2020

https://github.com/WordPress/gutenberg/issues?q=label%3A%22Needs+Dev+Note%22

These are all the PRs that need Dev Notes to be written for. Let's write them, share them here as comments, see what is related, and create make/core posts accordingly. Please let me know if you're unable to write a note for our PR. The notes should be posted before WP 5.5 RC, but the sooner, the better.

@youknowriad

@aduth (These need to be taken over, cc @WordPress/gutenberg-core.)

@gziolo

@nerrad

@tellthemachines

Unmarked

@ellatrix ellatrix added the [Type] Tracking Issue Tactical breakdown of efforts across the codebase and/or tied to Overview issues. label Jul 3, 2020
@youknowriad
Copy link
Contributor

There's a few of these that are still experimental, in that case, we shouldn't write a dev note for them but leave the label for later when the API is made stable.

@gziolo
Copy link
Member

gziolo commented Jul 3, 2020

Block API: Add new utility to register block types from metadata in PHP #20794

As part of that, we should also update https://github.com/WordPress/gutenberg/blob/master/docs/rfc/block-registration.md and move to the final location.

@nerrad
Copy link
Contributor

nerrad commented Jul 3, 2020

What's the deadline for the Dev notes to be written? I can write one for createInterpolateElement but knowing the deadline will help me plan when I write it.

@youknowriad
Copy link
Contributor

@nerrad Something like a month (before RC) but the sooner, the better :).

@gziolo
Copy link
Member

gziolo commented Jul 4, 2020

There are some issues reported about “Enqueue assets for rendered blocks only” (#22754) and it feels like we should revert it. If we don’t find a working solution for all cases on Monday, we should postpone it to WP 5.6.

@ellatrix
Copy link
Member Author

ellatrix commented Jul 5, 2020

@gziolo Are we depending on it for anything? If not, perhaps better to be safe and revert? It seems quite tricky.

@gziolo
Copy link
Member

gziolo commented Jul 6, 2020

#22754 was reverted with #23708 and moved to WordPress 5.6 in the corresponding core ticket.

@tellthemachines
Copy link
Contributor

tellthemachines commented Jul 8, 2020

Here's a dev note draft for the resizable editor/new preview options:

New editor preview options

You can now preview editor content in different screen sizes. Replacing the old preview button there is now a dropdown with “Desktop”, “Tablet” and “Mobile” sizes, as well as the previous front end preview option.

The new preview options currently only work on medium to large screens (>= 600px). In the future, there may be a way to preview large screens on a phone.

Block developers

If you’re a block developer and would like to have responsive styles for your blocks in the editor, use the #start-resizable-editor-section and#end-resizable-editor-section markers to define responsive styles. Styles between these markers will be picked up by the editor and render correctly when it is resized. As an example, this is what your styles would look like:

#start-resizable-editor-section {
    display: none;
}

/* add all responsive styles here */

#end-resizable-editor-section {
    display: none;
}

Currently, we aren’t able to manipulate theme editor styles because they are loaded inline in a <style> tag, instead of a separate stylesheet.

Other uses

The media query-manipulating hook, useSimulatedMediaQuery, takes a string to be used as a marker, so it can be used in other contexts, with different makers, for different styles.

Discussion around further features can be found in #19082

@noisysocks
Copy link
Member

Block API: Add Block Context support #21467 (see https://github.com/WordPress/gutenberg/blob/master/docs/designers-developers/developers/block-api/block-context.md)

I came here to write a dev note for block context, but I don't think I can do better than what @aduth wrote in the documentation that's linked there, so I suggest we just use that! 🙂

@gziolo
Copy link
Member

gziolo commented Jul 9, 2020

Blocks: Update default block categories

@aduth shared a proposed dev note for a new list of block categories in #19279 (comment):

Block API: Allow block registration without category

The Block category is no longer mandatory or doesn't have to match an existing category slug during block's registration. When that happens then a block is rendered in the inserter under the Uncategorized section.

@gziolo
Copy link
Member

gziolo commented Jul 9, 2020

Block API: Add new utility to register block types from metadata in PHP #20794

I opened PR #23832 that convert Block Registration RFC into a documentation page for Block Metadata that should serve as a source for dev note (it might need some refinements):

https://github.com/WordPress/gutenberg/blob/c5d28282538838aefa37a2a7c570dbfd4b00fff4/docs/designers-developers/developers/block-api/block-metadata.md

@TimothyBJacobs
Copy link
Member

Dev notes have been drafted for all the REST API changes. Most related to Gutenberg is https://make.wordpress.org/core/?p=82418&preview=true

@nerrad
Copy link
Contributor

nerrad commented Jul 13, 2020

Dev notes are drafted for createInterpolateElement: https://make.wordpress.org/core/?p=82449&preview=1&_ppp=0942283df4

If there are no suggested edits by Friday, I'll publish then.

@youknowriad
Copy link
Contributor

I think we should write a dev note about the new opt-in features for blocks: line-height, padding comes to my mind but maybe there are other block tools I'm missing. cc @ellatrix @ItsJonQ

@ItsJonQ
Copy link

ItsJonQ commented Jul 13, 2020

@youknowriad At the moment, line-height is opt-out. I'll make an update to make it opt-in, to be more consistent with the recent properties like spacing or link colour

@oandregal
Copy link
Member

@ellatrix I've removed the "needs dev note" from #22722 as this still requires the plugin to work and it won't be ported to 5.5 (see). Going to edit the issue description to remove it from here as well.

@ellatrix
Copy link
Member Author

@tellthemachines What other APIs are introduced apart from useSimulatedMediaQuery? Could these APIs be marked unstable, considering that we're looking at using iframes instead to preview the content?

@youknowriad
Copy link
Contributor

I'm going to remove Update the theme colors to rely on CSS variables #23048 for now. I'm working on bringing this setup to Core more globally for 5.6. So I think it's better to wait for this one.

@youknowriad
Copy link
Contributor

I'm also removing the ones about the color support flag as it's still experimental.

@mkaz
Copy link
Member

mkaz commented Jul 20, 2020

Is there an Image Editing dev note? @youknowriad raised in #23966 to attach the method to disable (that PR also needs to be back-ported to WP 5.5). If a dev note is started the description at the top of the PR can be included for disabling.

@diegohaz
Copy link
Member

#23316 will not be part of 5.5 release (I guess). Do dev notes still make sense in this case?

@youknowriad
Copy link
Contributor

@diegohaz I guess it was added just to make sure we don't forget. For now, it seems better to leave it for the next WP release.

@tellthemachines
Copy link
Contributor

@tellthemachines What other APIs are introduced apart from useSimulatedMediaQuery? Could these APIs be marked unstable, considering that we're looking at using iframes instead to preview the content?

We have getPreviewDeviceType and setPreviewDeviceType in the block-editor store, but wouldn't these be unchanged with the iframe solution?

We also have useResizeCanvas in the edit-post package. That's used to check that the current screen size isn't bigger than the size we want to resize to, and also to check if the screen itself gets resized at any point. Not sure this would be considered API as it's more of an implementation detail, and would have to change anyway if/when we implement emulation of large sizes on small screens.

Should we mark useSimulatedMediaQuery unstable? As that is definitely specific to this implementation. And in that case, should it be mentioned in the dev notes at all?

@ellatrix
Copy link
Member Author

I think we should mark useSimulatedMediaQuery unstable.

@tellthemachines
Copy link
Contributor

I think we should mark useSimulatedMediaQuery unstable.

Done: #24279 . Does it still require a dev note?

@aduth
Copy link
Member

aduth commented Jul 30, 2020

I noticed that the URLInput autoFocus default prop value was announced as a change pending in WordPress 5.5, but the associated pull request #19973 was never merged. I don't think it's going to be part of 5.5?

I'm having a hard time recalling what was preventing #19973 from being merged, aside from fighting with the test suite.

@youknowriad
Copy link
Contributor

Oh! what a mistake; I updated the post and removed that section for now. Thanks for catching that @aduth

@ellatrix
Copy link
Member Author

ellatrix commented Aug 6, 2020

This looks complete. Thanks everyone!

@ellatrix ellatrix closed this as completed Aug 6, 2020
WordPress 5.5 Must Have automation moved this from To do to Done Aug 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Tracking Issue Tactical breakdown of efforts across the codebase and/or tied to Overview issues.
Projects
No open projects
Development

No branches or pull requests