Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WordPress embed block is not hiding the blockquote #21945

Closed
david-binda opened this issue Apr 28, 2020 · 2 comments · Fixed by #25370
Closed

WordPress embed block is not hiding the blockquote #21945

david-binda opened this issue Apr 28, 2020 · 2 comments · Fixed by #25370
Assignees
Labels
[Block] Embed Affects the Embed Block [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended

Comments

@david-binda
Copy link
Contributor

Describe the bug
WordPress oembeds provide a blockquote fallback for cases where the iframe cannot be rendered ( see https://build.trac.wordpress.org/browser/trunk/wp-includes/embed.php?rev=47325#L449 and https://build.trac.wordpress.org/browser/trunk/wp-includes/js/wp-embed.js?rev=43426#L50 ).

In classic editor, this feature works as expected, but in Gutenberg / Block editor the blockquote can still be seen.

To reproduce
Steps to reproduce the behavior:

  1. Go to a new post screen in wp-admin
  2. Enter an embeddable link of your own site
  3. Note the post title being above the iframe

Expected behavior
The blockquote should be hidden as it is in the classic editor.

Screenshots
classic-editor-with-hidden-blockquote
gutenberg-with-visible-blockquote

Editor version (please complete the following information):

  • WordPress version: 5.5-alpha-47572
  • Does the website has Gutenberg plugin installed, or is it using the block editor that comes by default? Reprodubible in both, default and gutenberg plugin
  • If the Gutenberg plugin is installed, which version is it? 4.8.1

Desktop (please complete the following information):

  • OS: macOS
  • Browser: chrome
  • Version: 81.0.4044.122
@talldan talldan added [Block] Embed Affects the Embed Block Needs Testing Needs further testing to be confirmed. labels Apr 29, 2020
@ntsekouras ntsekouras added [Type] Bug An existing feature does not function as intended and removed Needs Testing Needs further testing to be confirmed. labels Sep 15, 2020
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Sep 16, 2020
@davideprevosto
Copy link

Hello,

it seems to me this issue appears again on WordPress 5.9.

Am I doing something wrong or someone is catching the same problem?

Thank you

@xfechx
Copy link

xfechx commented Mar 9, 2022

Hello,

I am getting all of the sudden automatic embeds in my site, when upgrading to Wordpress 5.9 and it is breaking things. Why is this not an option, why is it automatic? Such bad design choice!

Can someone help please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Embed Affects the Embed Block [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants