Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop downs for text settings too tall #19472

Closed
karmatosed opened this issue Jan 7, 2020 · 3 comments · Fixed by #19479
Closed

Drop downs for text settings too tall #19472

karmatosed opened this issue Jan 7, 2020 · 3 comments · Fixed by #19479
Labels
[Package] Components /packages/components

Comments

@karmatosed
Copy link
Member

This is what I see on paragraph settings in Twenty Twenty:

image

Here it is in Twenty Nineteen:

image

@karmatosed karmatosed added the [Package] Components /packages/components label Jan 7, 2020
@ItsJonQ
Copy link

ItsJonQ commented Jan 7, 2020

Thanks for reporting this @karmatosed ! I'll take a look at it in a moment 🙇

@ItsJonQ
Copy link

ItsJonQ commented Jan 7, 2020

Update! Found the issue.

The new FontSizePicker needs to adjust it's <Button /> size to small, to match the inputs/buttons it sits next to.

The updated FontSizePicker uses CustomSelectControl underneath. Will need to update that to accept button modifications :)

https://github.com/WordPress/gutenberg/blob/master/packages/components/src/custom-select-control/index.js

@karmatosed
Copy link
Member Author

Oh wow that's some sleuthing! Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Package] Components /packages/components
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants