Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Table Block: Toggling Header/Footer rows results in lost data #18919

Closed
shaunandrews opened this issue Dec 4, 2019 · 3 comments
Closed

Table Block: Toggling Header/Footer rows results in lost data #18919

shaunandrews opened this issue Dec 4, 2019 · 3 comments
Labels
[Block] Table Affects the Table Block Needs Decision Needs a decision to be actionable or relevant [Type] Bug An existing feature does not function as intended

Comments

@shaunandrews
Copy link
Contributor

When working with a table block, I found that toggling the Header/Footer sections can lead to a loss of input data. To reproduce, try this:

  1. Add a table block to your document.
  2. Turn on the Header section from the block sidebar.
  3. Add text to any Header section cell.
  4. Turn off the Header section from the block sidebar.
  5. Turn on the Header section from the block sidebar.

After toggling the Header, I'd expect the text added to the Header cell to be retained. Instead, the text is removed and all cells are no empty.

table header toggle

@shaunandrews shaunandrews added the [Type] Bug An existing feature does not function as intended label Dec 4, 2019
@shaunandrews shaunandrews added the [Block] Table Affects the Table Block label Dec 4, 2019
@shaunandrews shaunandrews changed the title Table Block: Toggling Header/Footer rows results is lost data Table Block: Toggling Header/Footer rows results in lost data Dec 4, 2019
@talldan
Copy link
Contributor

talldan commented Dec 11, 2019

After toggling the Header, I'd expect the text added to the Header cell to be retained. Instead, the text is removed and all cells are no empty.

Thanks for creating the issue. For some background, this was discussed pretty extensively in the initial PR and the decision was that is wasn't needed since undo/redo work for restoring the data:
#15409 (comment)

Given that, I'm going to add the Needs decision label. Perhaps it'd be something you could raise as a point in one of the design meetings, @shaunandrews?

@talldan talldan added the Needs Decision Needs a decision to be actionable or relevant label Dec 11, 2019
@ntsekouras
Copy link
Contributor

Hey @talldan and @shaunandrews! Had you discussed this back then in a design meeting or somewhere else?

Since there is an alternative with undo and there were no other references about this since then, should we close this issue and the respective PR?

@shaunandrews
Copy link
Contributor Author

I'd still consider this an issue, but I might be alone. I'll close it myself as it doesn't seem like there's much to do here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Table Affects the Table Block Needs Decision Needs a decision to be actionable or relevant [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants