Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't have a paragraph block start with an asterisk and a space editing visually #13134

Closed
cameronjonesweb opened this issue Dec 29, 2018 · 4 comments · Fixed by #13917
Closed
Labels
[Block] Paragraph Affects the Paragraph Block [Feature] History History, undo, redo, revisions, autosave. [Feature] Rich Text Related to the Rich Text component that allows developers to render a contenteditable Needs Technical Feedback Needs testing from a developer perspective.

Comments

@cameronjonesweb
Copy link
Contributor

If you start a paragraph with an asterisk and a space, the paragraph will be converted to an unordered list (expected behaviour). However when I undo using ctrl + Z or the undo button, the list is turned back to a paragraph but also removes the space after the asterisk. I would expect the undo to just undo the block conversion, not remove the space. This happens regardless of whether or not there is more text after the asterisk.

Thankfully, as a workaround, adding in the space by editing as HTML works and the space persists after swapping back to editing the block visually.

@youknowriad
Copy link
Contributor

@iseulde I know there have been some work to make undo capable of fixing this issue. Did we merge that yet?

@swissspidy swissspidy added Needs Technical Feedback Needs testing from a developer perspective. [Block] Paragraph Affects the Paragraph Block [Feature] History History, undo, redo, revisions, autosave. labels Jan 4, 2019
@talldan
Copy link
Contributor

talldan commented Jan 11, 2019

Duplicate issue here: #13284

Describe the bug
Putting a dash+space in the beginning of a paragraph line converts the block into a list, and forcing it back to a paragraph erases the dash.

While it is visually quite understandable (although not universally welcome) that the list was automatically created, it takes some time for a new user to understand that it is not a formatting option but a change of paragraph type, turning into frantic clicking in attempts to deactivate the list type button that looks to be at fault.

Changing the block back to paragraph erases the dash. Although I've found a workaround of forcing a dash there by copy/paste, a user won't be able/agree to.

"But why would anyone ever do that?" - because sometimes you need to write:
"A heading font statement or a quote or an image"
" - an explanation in other font"

@ellatrix ellatrix added the [Feature] Rich Text Related to the Rich Text component that allows developers to render a contenteditable label Feb 18, 2019
@ellatrix
Copy link
Member

Lost track of this issue.

@ellatrix
Copy link
Member

This is fixed by #13917, which is ready for review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Paragraph Affects the Paragraph Block [Feature] History History, undo, redo, revisions, autosave. [Feature] Rich Text Related to the Rich Text component that allows developers to render a contenteditable Needs Technical Feedback Needs testing from a developer perspective.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants