Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove local RichText state in favor of global selection state #11616

Closed
atimmer opened this issue Nov 8, 2018 · 2 comments · Fixed by #14640
Closed

Remove local RichText state in favor of global selection state #11616

atimmer opened this issue Nov 8, 2018 · 2 comments · Fixed by #14640
Labels
[Feature] Annotations Adding annotation functionality [Feature] Plugins API Extending the Gutenberg project with plugins via the Plugins API [Package] Editor /packages/editor [Type] Enhancement A suggestion for improvement.
Milestone
WordPress 5.x

Comments

@atimmer
Copy link
Member

atimmer commented Nov 8, 2018

Spinning out from #7718.

@iseulde mentioned that we can drop the local state of RichText in favor of the global state introduced in #7718. This does require some investigation, because the local state in the RichText instances only track their own state. But if they use the global state the all track the state of the last RichText that had a selection change. I don't know what consequences this has.
@atimmer atimmer added [Type] Enhancement A suggestion for improvement. [Feature] Plugins API Extending the Gutenberg project with plugins via the Plugins API [Package] Editor /packages/editor labels Nov 8, 2018
@atimmer atimmer mentioned this issue Nov 8, 2018
Merged
4 tasks
@ellatrix ellatrix added this to the WordPress 5.0.x Follow Ups milestone Nov 26, 2018
@ellatrix
Copy link
Member

Yes, we definitely want to do this. It will also be useful to reset selecting after undoing changes. Related: #12002.

@omarreiss omarreiss added the [Feature] Annotations Adding annotation functionality label Mar 26, 2019
@ellatrix ellatrix mentioned this issue Apr 4, 2019
Merged
5 tasks
@ellatrix
Copy link
Member

ellatrix commented Apr 4, 2019

@atimmer If you're interested, I made a PR: #14640.

@ellatrix ellatrix mentioned this issue Apr 4, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[Feature] Annotations Adding annotation functionality [Feature] Plugins API Extending the Gutenberg project with plugins via the Plugins API [Package] Editor /packages/editor [Type] Enhancement A suggestion for improvement.
Projects
None yet
Milestone
WordPress 5.x
Development

Successfully merging a pull request may close this issue.

Block Editor: move selection state from RichText to the store WordPress/gutenberg
4 participants
@youknowriad @atimmer @omarreiss @ellatrix