WithHeader cannot handle multiple requests with the same header key values

[robvangeloven]

When using the assertion "WithHeader" it will fail if there are multiple requests with the same header value (e.g. "Accept"):

Server.Should().HaveReceivedACall().WithHeader("Authorization", $"Bearer xxxxxxx");

This is because there is a ToDictionary in the WithHeader function that doesn't take into account that multiple calls might have been made before the assert fires.

[StefH]

@robvangeloven

I think I've fixed both issues (this & _callscount).

Can you please test preview version 1.5.6-ci-16474?

(https://github.com/WireMock-Net/WireMock.Net/wiki/MyGet-preview-versions)

#816

[StefH]

@robvangeloven

Did you have time to validate?

[robvangeloven]

@StefH Sorry, only now have time to test. The package version you mention is (no longer) available. Which version should I take for testing?

[StefH]

can you please try 16510?

[robvangeloven]

Tried it and failed, decompilation seems to show that the code isn't merged into that branch yet. Is that possible?

[StefH]

Sorry, wrong branch.

This id: 16511 should be it.

[robvangeloven]

Tried it! However it now tries to match the first request made to WireMock whereas the request I'm trying to match (via the AtUrl call) is the last request

[StefH]

@robvangeloven
Thanks for testing.

Can you please take a look at this unit test file?
https://github.com/WireMock-Net/WireMock.Net/pull/816/files#diff-e73254164873009a752dfd094e87fa8aae2d0c6c0c0b7ebe3b6d2f2b23b287c8

See line 463.

[StefH]

#816

[robvangeloven]

@robvangeloven Thanks for testing.

Can you please take a look at this unit test file? https://github.com/WireMock-Net/WireMock.Net/pull/816/files#diff-e73254164873009a752dfd094e87fa8aae2d0c6c0c0b7ebe3b6d2f2b23b287c8

See line 463.

I've checked the unit test, but that one doesn't actually check any headers?

[StefH]

Correct.

I did combine both your issues into 1 PR.

And I think both issues are solved.

In case you still have an issue, please provide a unit test.

[robvangeloven]

Yes, retested everything and both issues are fixed!

[StefH]

Thanks for retesting. A new NuGet version will be released this weekend.

[StefH]

#816