-
-
Notifications
You must be signed in to change notification settings - Fork 204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Admin API] Find a request that matched a given mapping #1039
Comments
Some possible options to solve this;
What would be the best design? |
Hi, Thanks for your reply. The |
@tlevesque-ueat |
On the same endpoint? How would it differentiate between the two? |
@tlevesque-ueat See PR: An preview version |
That's perfect, thanks! |
No, I do not have anything setup in the pipeline to also build a preview versions for docker versions. |
It's OK, I'll wait for the non-preview release. I have a workaround, so I'm not in a hurry. |
@tlevesque-ueat |
Awesome, thanks! Will try it now |
It works fine, thanks! Just one thing, though: it only returns one request, but there could be multiple requests that match the same mapping GUID... It would probably be better to return a collection of requests. I'll make some comments on the PR. I should have reviewed more carefully when you made the PR, sorry about that... |
You can also create a PR yourself for that. |
Sure, I will. If you don't mind the breaking change (hopefully the new endpoint is recent enough that nobody is already relying on it...) |
Maybe I'm missing something, but I can't find a way to find a request that matched a mapping, given the mapping GUID, using the Admin API.
The request body for the
POST /__admin/requests/find
endpoint takes aRequestModel
, butMappingGuid
is a property ofLogEntryModel
, so it doesn't seem like I can do it using this endpoint.The
GET /__admin/requests/{guid}
endpoint takes the GUID of the request, not the mapping, so it's not helpful since I don't know the request GUID.Is there anyway to achieve what I want? It would be very useful, to avoid repeating the whole request specification to verify if a request was made.
As a workaround, I currently use
GET /__admin/requests
and check against the whole list to see if a request matched the mapping, but it's not ideal.The text was updated successfully, but these errors were encountered: