-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PrimarySources suggestions can't be rejected on Chrome #118
Comments
This might be due to a conflict in the handling of click events, but this surely has been tested on Chrome originally, so it might be new. Could you also post which version of Chrome you are using and which page the problem can be seen on? |
Chrome version 59.0.3071.86 (Official Build) (64-bit) on Linux. |
Indeed, I can confirm this behaviour on my machine, with almost the same version of Chromium. I wonder if this affects the accept and reject buttons in all cases now. |
For some reason the userinfo promise has no .success() and .error() methods. This method is deprecated anyway and it is recommend to use .then() instead. There might be more places where these functions are used. So maybe this code should be refactored as well. |
It seems like this will need some more refactoring anyway to integrate the inferred statements; I'll keep that in mind, thanks. |
Clicking the little [x] does not dismiss the suggestion, but instead collapses/expands the details.
The text was updated successfully, but these errors were encountered: