Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PrimarySources suggestions can't be rejected on Chrome #118

Closed
abartov opened this issue Aug 1, 2017 · 5 comments
Closed

PrimarySources suggestions can't be rejected on Chrome #118

abartov opened this issue Aug 1, 2017 · 5 comments
Assignees
Labels
bug Something isn't working view: Entity This relates to the entity view

Comments

@abartov
Copy link

abartov commented Aug 1, 2017

Clicking the little [x] does not dismiss the suggestion, but instead collapses/expands the details.

@mkroetzsch
Copy link
Member

This might be due to a conflict in the handling of click events, but this surely has been tested on Chrome originally, so it might be new. Could you also post which version of Chrome you are using and which page the problem can be seen on?

@mkroetzsch mkroetzsch added bug Something isn't working view: Entity This relates to the entity view labels Aug 1, 2017
@abartov
Copy link
Author

abartov commented Aug 1, 2017

Chrome version 59.0.3071.86 (Official Build) (64-bit) on Linux.
I saw the behavior on e.g. https://tools.wmflabs.org/sqid/#/view?id=Q151872
(try [correctly] rejecting the suggested "Judaism".)

@mkroetzsch
Copy link
Member

Indeed, I can confirm this behaviour on my machine, with almost the same version of Chromium. I wonder if this affects the accept and reject buttons in all cases now.

@guenthermi
Copy link
Member

For some reason the userinfo promise has no .success() and .error() methods. This method is deprecated anyway and it is recommend to use .then() instead. There might be more places where these functions are used. So maybe this code should be refactored as well.

@mmarx
Copy link
Member

mmarx commented Aug 1, 2017

It seems like this will need some more refactoring anyway to integrate the inferred statements; I'll keep that in mind, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working view: Entity This relates to the entity view
Projects
None yet
Development

No branches or pull requests

4 participants