-
-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Struct member access doesn't work on the left-hand side of +=, nor the left-hand side within patterns #87
Comments
the only problem i see in your example code that wasn't already known is that += is not working as it should. there is a known problem using the dot operator on the left side of assignments inside structures that needs to be looked at. maybe the title of this issue should be changed to specify that the problem occurs only inside structures. |
I tried to look first, but I didn't find an open issue about this in neither ImHex's nor PatternLanguage's repositories.
|
I'm sorry, I didn't express myself correctly. By known problem I meant known as a result of out recent exchanges as I mentioned it in one of the issues you opened. My suggestion of the name change is only to help the person who tries to fix it find the problem faster. The fact that abc.var = abc.var + 5; works outside of the struct seems to indicate that there is no problem with the dot operator used on the right hand side of an assignment and that += not working must be unrelated since both should mean the same thing. |
Using the version of Pattern Language in ImHex v1.33.2, if
abc
is a struct, thenabc.var
is a little picky on the left-hand side of assignments in the global scope, and very picky on the left-hand side of assignments within structs (regardless of whetherabc
is a global struct or a member of the struct currently being parsed).(This might explain half of WerWolv/ImHex#1599 ?)
Note the
//This does not work
comments in...The text was updated successfully, but these errors were encountered: