Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is this X_tilde_3 or X_c? #26

Closed
lzylzylllll opened this issue Jul 12, 2023 · 7 comments
Closed

Is this X_tilde_3 or X_c? #26

lzylzylllll opened this issue Jul 12, 2023 · 7 comments

Comments

@lzylzylllll
Copy link

        imputation_MAE = masked_mae_cal(
            X_tilde_3, inputs["X_holdout"], inputs["indicating_mask"]
        )
@WenjieDu
Copy link
Owner

Hi there,

Thank you so much for your attention to SAITS! If you find SAITS is helpful to your work, please star⭐️ this repository. Your star is your recognition, which can let others notice SAITS. It matters and is definitely a kind of contribution.

I have received your message and will respond ASAP. Thank you again for your patience! 😃

Best,
Wenjie

@WenjieDu
Copy link
Owner

WenjieDu commented Jul 12, 2023

Yeah, I know this. No worries. The parts in X_tilde_3 and X_c for this loss calculation are exactly the same.

@lzylzylllll
Copy link
Author

Do you mean X_tilde_3 and X_c values are equal?

@WenjieDu
Copy link
Owner

Of course they are not equal, there is code here to generate X_c from X_tilde_3 https://github.com/WenjieDu/SAITS/blob/main/modeling/saits.py#L193-L196. I mean the exactly what I said above the parts in X_tilde_3 and X_c for this loss calculation are exactly the same. You can replace X_tilde_3 with X_c in that line of code calculating imputation_MAE. The result will be the same.

@lzylzylllll
Copy link
Author

I understand, thanks for the answer

@WenjieDu
Copy link
Owner

Absolutely my pleasure. If it doesn't bother you, please star 🌟 this repo to help more people notice this useful work. Thanks.

@WenjieDu
Copy link
Owner

I'm closing this issue due to all questions solved. BTW, if you're interested in time series modeling, PyPOTS may be useful to you. Please pay a visit to https://pypots.com/ to know more about it. 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants