Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pd.concat #12

Closed
lidamsoukaina opened this issue Apr 5, 2023 · 3 comments · Fixed by #13
Closed

pd.concat #12

lidamsoukaina opened this issue Apr 5, 2023 · 3 comments · Fixed by #13

Comments

@lidamsoukaina
Copy link

FutureWarning: The frame.append method is deprecated and will be removed from pandas in a future version. Use pandas.concat instead.

@WenjieDu
Copy link
Owner

WenjieDu commented Apr 5, 2023

Hi there,

Thank you so much for your attention to SAITS! If you find SAITS is helpful to your work, please star⭐️ this repository. Your star is your recognition, which can let others notice SAITS. It matters and is definitely a kind of contribution.

I have received your message and will respond ASAP. Thank you again for your patience! 😃

Best,
Wenjie

@WenjieDu
Copy link
Owner

WenjieDu commented Apr 5, 2023

Right, I noticed this warning while building PyPOTS. I didn't update the code in this repo because the versions of the dependencies are fixed in conda_env_dependencies.yml so I thought it wouldn't be a problem. Considering users may copy and use the code in their own dev env, the warning you point out here can possibly cause problems in the future. I'm going to create a PR to help solve this issue. I will reference the PR here and invite you to review the code. Thank you very much for your contribution, Soukaina! 👍

@WenjieDu
Copy link
Owner

WenjieDu commented Apr 5, 2023

PR #13 has been created. @lidamsoukaina Please review the code. 😊

@WenjieDu WenjieDu linked a pull request Apr 5, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants