Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate each model into a single package #85

Closed
WenjieDu opened this issue May 5, 2023 · 0 comments · Fixed by #86
Closed

Separate each model into a single package #85

WenjieDu opened this issue May 5, 2023 · 0 comments · Fixed by #86
Assignees
Labels
enhancement New feature or request new feature Proposing to add a new feature

Comments

@WenjieDu
Copy link
Owner

WenjieDu commented May 5, 2023

1. Feature description

PyPOTS may should separate each model into a single package. Take SAITS as an example, its package structure should be like below

├── pypots
│	├── imputation
│	│	├── saits
│	│	│	├── __init__.py
│	│	│	├── dataset.py
│	│	│	├── model.py
│	│	│	└── module.py
  • model.py includes the main model/algorithm and the wrapper exposed to users;
  • module.py includes layers and modules for the main model/algorithm if necessary;
  • dataset.py includes specifically-designed class Dataset for this model's data processing;

2. Motivation

To make the library more standardized, and for easier management.

3. Your contribution

Will create a PR to finish this.

@WenjieDu WenjieDu added enhancement New feature or request new feature Proposing to add a new feature labels May 5, 2023
@WenjieDu WenjieDu self-assigned this May 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request new feature Proposing to add a new feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant