Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add git hooks for linting before code committing or push #67

Closed
WenjieDu opened this issue Apr 22, 2023 · 0 comments · Fixed by #68
Closed

Add git hooks for linting before code committing or push #67

WenjieDu opened this issue Apr 22, 2023 · 0 comments · Fixed by #68
Assignees
Labels
new feature Proposing to add a new feature

Comments

@WenjieDu
Copy link
Owner

Feature description

We run a code-linting workflow on pushes. Although we already have a lint-checking tool in pypots-cli dev --lint-code, I figure out that I sometimes forget to run it and commit code with lints. This could result in unnecessary troubles like code modification and re-pushing. Hence, we should have some git hooks for PyPOTS project to help solve this problem, tools like pre-commit may be useful.

Motivation

See the description above. We don't want to put all checking and testing things on CI and cloud. We need some more normative rules for code development here.

Your contribution

Will create a PR and link it to this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new feature Proposing to add a new feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant