Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow customized loss function for imputation/informer #432

Open
mmo139 opened this issue Jun 16, 2024 · 1 comment
Open

allow customized loss function for imputation/informer #432

mmo139 opened this issue Jun 16, 2024 · 1 comment
Labels
enhancement New feature or request new feature Proposing to add a new feature

Comments

@mmo139
Copy link

mmo139 commented Jun 16, 2024

1. Feature description

Add the customized_loss_func feature currently available in SAITS to other imputation models.

2. Motivation

Currently saits_loss_func is used in class _Informer (line 96 of pypots/imputation/informer/core.py), indicating that loss function is MAE and cannot be customized with a model parameter (the original paper used MSE). I adjusted locally for my task for using MSE but it would be nice if customized_loss_func can also be added for informer. Besides, it seems some other models are using saits_loss_func in core.py as well (but I didn't check one by one).

3. Your contribution

I can help with updating core.py / model.py but not sure if rolling out the feature for other models are also desired.

@mmo139 mmo139 added enhancement New feature or request new feature Proposing to add a new feature labels Jun 16, 2024
Copy link

Hi there 👋,

Thank you so much for your attention to PyPOTS! You can follow me on GitHub to receive the latest news of PyPOTS. If you find PyPOTS helpful to your work, please star⭐️ this repository. Your star is your recognition, which can help more people notice PyPOTS and grow PyPOTS community. It matters and is definitely a kind of contribution to the community.

I have received your message and will respond ASAP. Thank you for your patience! 😃

Best,
Wenjie

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request new feature Proposing to add a new feature
Projects
None yet
Development

No branches or pull requests

1 participant