Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Positional encoding not applied in v0.5 imputation Nonstationary-Transformer and Pyraformer #411

Closed
1 of 2 tasks
WenjieDu opened this issue May 13, 2024 · 0 comments
Closed
1 of 2 tasks

Positional encoding not applied in v0.5 imputation Nonstationary-Transformer and Pyraformer #411

WenjieDu opened this issue May 13, 2024 · 0 comments
Assignees
@WenjieDu
Labels
bug Something isn't working

Comments

@WenjieDu
Copy link
Owner

1. System Info

PyPOTS v0.5

2. Information

  • The official example scripts
  • My own created scripts

3. Reproduction

PyPOTS/pypots/imputation/nonstationary_transformer/core.py

Line 43 in 9cdd37a

with_pos=False,

PyPOTS/pypots/imputation/pyraformer/core.py

Line 36 in 9cdd37a

with_pos=False,

4. Expected behavior

The positional encoding is not applied to Nonstationary Transformer and Pyraformer in the imputation package of PyPOTS v0.5, should be fixed.
@WenjieDu WenjieDu added the bug Something isn't working label May 13, 2024
@WenjieDu WenjieDu self-assigned this May 13, 2024
@WenjieDu WenjieDu mentioned this issue May 13, 2024
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@WenjieDu WenjieDu

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@WenjieDu