Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PyPOTS_tutorials.ipynb not working due to Old Edition #305

Closed
Six-Persimmon opened this issue Feb 28, 2024 · 3 comments · Fixed by WenjieDu/BrewPOTS#14
Closed

PyPOTS_tutorials.ipynb not working due to Old Edition #305

Six-Persimmon opened this issue Feb 28, 2024 · 3 comments · Fixed by WenjieDu/BrewPOTS#14
Assignees
Labels
bug Something isn't working

Comments

@Six-Persimmon
Copy link

Six-Persimmon commented Feb 28, 2024

1.Problem Discription

  1. In the online Colab tutorial file enclosed in the "Quick-start Examples" section of the PyPOTS document, the codes start with an out-of-date line ! pip install pypots==0.1.1that causes a tsdb problem in line physionet2012_dataset = gene_physionet2012(artificially_missing_rate=0.1).
    The problem can be solved by instead using ! pip install pypots==0.3.1.

  2. In all the tutorial files, the dataset obtained by:

physionet2012_dataset = gene_physionet2012(artificially_missing_rate=0.1)

does not contain the key "val_X_intact". Therefore the following cell line:

dataset_for_validating = {
    "X": physionet2012_dataset['val_X'],
    "X_intact": physionet2012_dataset['val_X_intact'],
    "indicating_mask": physionet2012_dataset['val_X_indicating_mask'],
}

Will report error: KeyError: 'val_X_intact'

3. Reproduction

1.Click "You can also find a simple and quick-start tutorial notebook on Google Colab with this link." in the quick start document.
2. Run the code, it will report the errors.

@Six-Persimmon Six-Persimmon added the bug Something isn't working label Feb 28, 2024
@WenjieDu
Copy link
Owner

Hi there 👋,

Thank you so much for your attention to PyPOTS! You can follow me on GitHub to receive the latest news of PyPOTS. If you find PyPOTS helpful to your work, please star⭐️ this repository. Your star is your recognition, which can help more people notice PyPOTS and grow PyPOTS community. It matters and is definitely a kind of contribution to the community.

I have received your message and will respond ASAP. Thank you for your patience! 😃

Best,
Wenjie

@WenjieDu
Copy link
Owner

WenjieDu commented Feb 28, 2024

Thanks, Shijian @Six-Persimmon. I'll update the tutorials on Colab and in the BrewPOTS repo https://github.com/WenjieDu/BrewPOTS. Any interest in joining our community and collaborating?

@WenjieDu WenjieDu self-assigned this Feb 28, 2024
@Six-Persimmon
Copy link
Author

Thank you Wenjie! YES! I am reaching out to the contributor Yinghao (we have been friends since middle school😆) to see if PyPOTS can solve a specific group of Economic problems I am working on, and am very willing to join the community. Thank you for this awesome project!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants