Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug in MRNN, the model should iterate on each feature #283

Closed
1 of 2 tasks
WenjieDu opened this issue Dec 24, 2023 · 1 comment
Closed
1 of 2 tasks

Bug in MRNN, the model should iterate on each feature #283

WenjieDu opened this issue Dec 24, 2023 · 1 comment
Assignees
Milestone

Comments

@WenjieDu
Copy link
Owner

WenjieDu commented Dec 24, 2023

1. System Info

All PyPOTS versions.

2. Information

  • The official example scripts
  • My own created scripts

3. Reproduction

In the official implementation, MRNN iterates on each feature https://github.com/jsyoon0823/MRNN/blob/77227d49b99053cbfe4380255a247e819950e074/mrnn.py#L292-L294

4. Expected behavior

But in the PyPOTS' version, MRNN runs on all features.

@WenjieDu WenjieDu added bug Something isn't working potential bug and removed bug Something isn't working labels Dec 24, 2023
@WenjieDu WenjieDu self-assigned this Dec 25, 2023
@WenjieDu
Copy link
Owner Author

Didn't find any performance improvement on real-world datasets after fixing this issue. But the running speed is greatly slowed down because it needs to iterate *n_features times.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant