Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue about the updating strategy of term F in CRLI #225

Closed
1 of 2 tasks
WenjieDu opened this issue Nov 4, 2023 · 0 comments
Closed
1 of 2 tasks

Issue about the updating strategy of term F in CRLI #225

WenjieDu opened this issue Nov 4, 2023 · 0 comments
Assignees
Labels
bug Something isn't working
Milestone

Comments

@WenjieDu
Copy link
Owner

WenjieDu commented Nov 4, 2023

1. System Info

The updating strategy of term F in CRLI should be kept the same as the official implementation and the original paper.

2. Information

  • The official example scripts
  • My own created scripts

3. Reproduction

The current implementation:

term_F = torch.nn.init.orthogonal_(
torch.randn(batch_size, self.n_clusters, device=self.device), gain=1
)

4. Expected behavior

It is different from the official implementation in Tensorflow:

https://github.com/qianlima-lab/CRLI/blob/890b21a5ac4b0d18b4e1f292ee2e38cd2454d1a7/code/main.py#L411-L417

@WenjieDu WenjieDu added the bug Something isn't working label Nov 4, 2023
@WenjieDu WenjieDu self-assigned this Nov 4, 2023
@WenjieDu WenjieDu added this to the v0.2 milestone Nov 4, 2023
@WenjieDu WenjieDu closed this as completed Nov 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant