Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enabling users to customize loss function #137

Closed
WenjieDu opened this issue May 25, 2023 · 0 comments
Closed

Enabling users to customize loss function #137

WenjieDu opened this issue May 25, 2023 · 0 comments
Assignees
Labels
enhancement New feature or request new feature Proposing to add a new feature
Milestone

Comments

@WenjieDu
Copy link
Owner

1. Feature description

Add a feature to enable users to specify their own loss functions, which should be callable python functions.

2. Motivation

Currently the loss functions in PyPOTS models are fixed. This definitely has no problem because reproducing algorithms and models exactly is an important part in PyPOTS project. Algorithms and models should be kept as same as possible with the descriptions from original papers.

However, users from time to time have to specify the loss function for better optimization. For example, in some scenarios, users use MAE as their evaluation metric to assess the imputation accuracy, while some other users with their applications prefer to use MSE to evaluate the final imputation results. From the perspective of helping our users get better results, we should add such a feature.

3. Your contribution

Will create a PR to finish it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request new feature Proposing to add a new feature
Projects
None yet
Development

No branches or pull requests

1 participant