Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unit test #8

Open
homerchen19 opened this issue Sep 9, 2017 · 1 comment
Open

Unit test #8

homerchen19 opened this issue Sep 9, 2017 · 1 comment
Labels
enhancement hacktoberfest

Comments

@homerchen19
Copy link

homerchen19 commented Sep 9, 2017 •
edited
Loading

Maybe you can split index.js into more function for unit test?
If you use prettier with ESLint, that is even better
@WeiChiaChang
Copy link
Owner

WeiChiaChang commented Sep 10, 2017 •
edited
Loading

Yeah indeed it really needs some code refactoring 👍
Still need to figure out the problem about the file size, since the base64 string just too big to compress. 😢

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement hacktoberfest
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@homerchen19 @WeiChiaChang