Yes or no, it depends on what you will try to do. Since I don't want to waste your time, be sure to create an empty draft pull request or open an issue, so we can have a discussion first. Especially for a large pull request or you don't know if it will be merged or not.
Here are some references:
- Bug fix
- Security fix
- Adding notification providers
- Adding new language keys
- Large pull requests
- New features
- Do not pass the auto-test(we dont have auto-test now)
- Any breaking changes
- Duplicated pull requests
- Buggy
- UI/UX is not close to saasfly
- Modifications or deletions of existing logic without a valid reason.
- Adding functions that is completely out of scope
- Converting existing code into other programming languages
- Unnecessarily large code changes that are hard to review and cause conflicts with other PRs.
The above cases may not cover all possible situations.
If your pull request does not meet my expectations, I will reject it, no matter how much time you spent on it. Therefore, it is essential to have a discussion beforehand.
I will assign your pull request to a milestone, if I plan to review and merge it.
Also, please don't rush or ask for an ETA, because I have to understand the pull request, make sure it is no breaking changes and stick to my vision of this project, especially for large pull requests.
Before deep into coding, discussion first is preferred. Creating an empty pull request for discussion would be recommended.
- Fork the project
- Clone your fork repo to local
- Create a new branch
- Create an empty commit:
git commit -m "<YOUR TASK NAME>" --allow-empty - Push to your fork repo
- Prepare a pull request: https://github.com/saasfly/saasfly/compare
- Write a proper description. You can mention @tianzx in it, so @tianzx will get the notification.
- Create your pull request as a Draft
- Wait for the discussion