-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release tag/name version and released file versions differ by a .0
#360
Comments
For wasi-sdk-21, I thought about this a bit: on the one hand, whatever scripts are out there have probably adapted to this inconsistency so "fixing" it might actually break other people's workflows. Also, having the minor version present is probably useful in case someone needs to patch a release. On the other hand, perhaps we could tag releases twice: |
True (me included).
But if that was ever not No good options, unfortunately, short of getting into package managers so it's their problem. 😉 |
The released files for the WASI SDK all have a
.0
at the end of their version, while the release names/tags don't. For example, https://github.com/WebAssembly/wasi-sdk/releases/tag/wasi-sdk-20 has https://github.com/WebAssembly/wasi-sdk/releases/download/wasi-sdk-20/wasi-sdk-20.0-linux.tar.gz ; notice the20
in the tag name but20.0
in the file name.This makes it a little tricky to download files as both names are used in the URL. For example, in a Docker file I have (notice the hard-coded
.0
in that URL):ENV WASI_SDK_VERSION=20 curl --location https://github.com/WebAssembly/wasi-sdk/releases/download/wasi-sdk-${WASI_SDK_VERSION}/wasi-sdk-${WASI_SDK_VERSION}.0-linux.tar.gz
Making sure to not leave off that
.0
is easy to forget. Same goes for where the tarball expands to (luckily in this case I can usetar --strip-components 1 --directory ${WASI_SDK_PATH}
to avoid this, but on my development machine I can't).Any chance future git tags/GitHub releases can include the full version?
The text was updated successfully, but these errors were encountered: