Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The wasi-sdk-20.0 for mingw contains an extra .m suffix #323

Closed
cphoskins opened this issue Apr 11, 2023 · 4 comments
Closed

The wasi-sdk-20.0 for mingw contains an extra .m suffix #323

cphoskins opened this issue Apr 11, 2023 · 4 comments

Comments

@cphoskins
Copy link

cphoskins commented Apr 11, 2023

wasi-sdk-20.0.m-mingw.tar.gz's contained directory is named wasi-sdk-20.0.m rather than wasi-sdk-20.0. Is the additional .m intentional? If so, that means the wasi-sdk retrieval and use between Linux and mingw now differ which would require conditional logic in our make files between platforms.

@abrown
Copy link
Collaborator

abrown commented Apr 12, 2023

I think what is going on here is that the version.sh script is appending an m to the version because the Git directory is changed:

GIT_DESCR=$(git describe --long --candidates=999 --match='wasi-sdk-*' --dirty='+m' --abbrev=12)

I don't know why this is, though. When I've hurriedly noticed this before I thought that it had something to do with the Windows action runners for CI — some difference between the Windows environment and the rest? I could just rename this artifact, which I'm happy to do, but this would continue to happen in future releases. Are you interested in looking into this?

@cphoskins
Copy link
Author

@abrown , I can take a look at it, but I wouldn't be able to start until 2023-04-21. If that works, then I would be happy to dig in.

@abrown
Copy link
Collaborator

abrown commented Apr 12, 2023

Yeah, that would be great! (cc: @yamt or @eloparco who had a similar comment about this recently, IIRC).

@alexcrichton
Copy link
Collaborator

I believe this is now fixed as of #429, so closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants