Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename typeof #2314

Merged
merged 2 commits into from
Oct 26, 2023
Merged

rename typeof #2314

merged 2 commits into from
Oct 26, 2023

Conversation

walkingeyerobot
Copy link
Contributor

While typeof is not a standard c++ keyword, it is in the gnu dialect (i.e. -std=gnu++17). Simply renaming typeof to typeoffunc and TypeOf to TypeOfFunc lets wabt be built with either dialect.

While typeof is not a standard c++ keyword, it is in the gnu dialect (i.e. -std=gnu++17). Simply renaming typeof to typeoffunc and TypeOf to TypeOfFunc lets wabt be built with either dialect.
src/c-writer.cc Outdated Show resolved Hide resolved
@sbc100 sbc100 requested a review from keithw October 26, 2023 20:40
Copy link
Member

@keithw keithw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@sbc100 sbc100 merged commit e97d53c into WebAssembly:main Oct 26, 2023
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants