Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add piper backend #238

Merged
merged 2 commits into from
Jul 11, 2024
Merged

Add piper backend #238

merged 2 commits into from
Jul 11, 2024

Conversation

PeterD1524
Copy link
Contributor

@PeterD1524 PeterD1524 commented Jun 28, 2024

Explanation

I am working on LFX Workspace: Support piper as a new backend of the WASI-NN WasmEdge plugin #3483.
This PR adds a tutorial to build the piper plugin.

Related issue

WasmEdge/WasmEdge#3483

What type of PR is this

/kind documentation

Signed-off-by: PeterD1524 <[email protected]>
Copy link
Collaborator

alabulei1 commented Jun 28, 2024

Hello, I am a code review bot on flows.network. Here are my reviews of code commits in this PR.


Commit 38fa81019202f4ec77eeb1377d9ab17036ee057e

Key Changes:

  1. Addition of documentation on building WasmEdge with WASI-NN Piper Backend in the wasi_nn.md file under the docs/contribute/source/plugin/ directory.
  2. Instructions provided for building and installing WasmEdge from source with the Piper backend for WASI-NN.
  3. Information on setting the WASMEDGE_PLUGIN_PATH environment variable if the wasmedge CLI tool cannot find the WASI-NN plug-in.

Potential Problems:

  1. Security Concerns: The patch includes an email address in the Signed-off-by section, which may expose personal information. It's recommended to use a username or display name instead.
  2. Consistency in Path: The patch mentions different paths for the executable wasmedge runtime and the WASI-NN with Piper backend plug-in installation. It would be good to ensure consistency in paths for better clarity.
  3. Error Handling: While the patch provides guidance on setting the WASMEDGE_PLUGIN_PATH environment variable if needed, it might be beneficial to include troubleshooting steps or potential reasons why the CLI tool cannot find the plug-in in the first place.

Copy link
Contributor

@mhmohona mhmohona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for updating doc! ✨

docs/contribute/source/plugin/wasi_nn.md Outdated Show resolved Hide resolved
@PeterD1524 PeterD1524 changed the title Add piper backend and fix some docs Add piper backend Jul 4, 2024
@hydai
Copy link
Member

hydai commented Jul 11, 2024

Hi @PeterD1524
Since you updated the same file in another PR, you will need to update this to fix the conflicts. Thanks.

Signed-off-by: PeterD1524 <[email protected]>
@hydai hydai merged commit aa028bf into WasmEdge:main Jul 11, 2024
6 checks passed
@PeterD1524 PeterD1524 deleted the piper branch July 11, 2024 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants