Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark the rustls plug-in as deprecated. #231

Merged
merged 1 commit into from
Aug 5, 2024
Merged

Mark the rustls plug-in as deprecated. #231

merged 1 commit into from
Aug 5, 2024

Conversation

q82419
Copy link
Collaborator

@q82419 q82419 commented Jun 3, 2024

No description provided.

Copy link
Collaborator

alabulei1 commented Jun 3, 2024

Hello, I am a code review bot on flows.network. Here are my reviews of code commits in this PR.


Commit 0a5d9bbd29da18e9d306b885f9572316c9864406

Key Changes:

  1. The GitHub Patch marks the rustls plug-in as deprecated after version 0.14.0.
  2. It provides a note explaining the deprecation and the replacement of rustls with reqwest.

Potential Problems:

  1. The patch changes multiple files, indicating a wide-reaching impact of deprecating the rustls plug-in.
  2. Users who rely on the rustls plug-in may need guidance on transitioning to the recommended reqwest alternative.
  3. The deprecation note could be more detailed, providing guidance on migration steps or alternatives for affected users.
  4. Ensuring that documentation and examples are updated to reflect the deprecation of the rustls plug-in and the adoption of reqwest.
  5. It might be necessary to update any tutorials or guides that reference the rustls plug-in to avoid confusion for users.

Overall, the deprecation of the rustls plug-in in favor of reqwest seems like a significant change that will require proper communication and documentation updates for impacted users.

@alabulei1
Copy link
Collaborator

Hi @juntao ,

Could you please help check out this PR?

@hydai
Copy link
Member

hydai commented Jul 10, 2024

@q82419 Please fix the conflicts

@hydai
Copy link
Member

hydai commented Aug 5, 2024

@q82419
Please fix the conflict.

@hydai hydai merged commit 5ac4031 into main Aug 5, 2024
6 checks passed
@hydai hydai deleted the yiying/rustls branch August 5, 2024 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants