Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update knative instructions #220

Merged
merged 1 commit into from
Apr 3, 2024
Merged

Update knative instructions #220

merged 1 commit into from
Apr 3, 2024

Conversation

dievskiy
Copy link
Contributor

Explanation

This PR fixes minor issues with the current knative setup guide. The update is needed to follow the instructions without the issues.

Related issue

N/A

What type of PR is this

/kind bug
/kind documentation

Proposed Changes

Fix minor issues

Copy link
Collaborator

alabulei1 commented Mar 10, 2024

Hello, I am a code review bot on flows.network. Here are my reviews of code commits in this PR.


Commit 558819b22492834b90f46761676189a7ab4ad251

Key Changes:

  1. Removed redundant export of KUBECONFIG, as it was previously set before applying the runtime.yaml file.
  2. Updated the command for applying the runtime.yaml file to use the -f flag, providing the filename explicitly.
  3. Corrected the command for applying the http-wasm-serverless.yaml file to use the -f flag, providing the filename explicitly.

Potential Problems:

  1. The redundant export of KUBECONFIG was removed, which seems like a good cleanup. No issues here.
  2. The command for applying the runtime.yaml file was corrected to use the -f flag; this is a necessary change to ensure the correct file is applied.
  3. The command for applying the http-wasm-serverless.yaml file was also corrected to use the -f flag; this correction is important to avoid errors in applying the file.

Overall, these changes seem beneficial and necessary for updating the Knative instructions. The changes appear to be focused on improving the clarity and correctness of the deployment instructions.

@alabulei1
Copy link
Collaborator

Hi @dievskiy

Thanks for your contribution. Could you please fix the DCO CI first?

@dievskiy
Copy link
Contributor Author

Should be fine now.

@alabulei1 alabulei1 merged commit 8a5a312 into WasmEdge:main Apr 3, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants