Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance Logging (stop the string concatenation madness) #99

Closed
hazendaz opened this issue Jun 14, 2014 · 2 comments
Closed

Enhance Logging (stop the string concatenation madness) #99

hazendaz opened this issue Jun 14, 2014 · 2 comments
Labels

Comments

@hazendaz
Copy link
Member

Logging is still using string concatenation. Since this library is now fully using slf4j, it is time to remove string concatenation from logging.

Example

log.debug("some field is: " + field);

Can be

log.debug("some field is: {}");

This will result in some gain to speed of waffle as we will no longer instantiate strings to log when we may not be logging at that level.

At the same time, we should get rid of any other string concatenation. Use simple method that will append strings cleaner than using stringBuilders throughout possibly using Guava which is already part of the library.

@hazendaz
Copy link
Member Author

hazendaz commented Jul 5, 2014

#101 is flagged with these changes. As soon as that is reviewed and accepted, will close this out. This was handled everywhere except where stringbuilders need used. Will work on that later as this was bigger than expected.

@dblock
Copy link
Collaborator

dblock commented Jul 6, 2014

Merged.

@dblock dblock closed this as completed Jul 6, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants