Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement an enabled flag for all filters #639

Open
dblock opened this issue Jul 6, 2018 · 4 comments
Open

Implement an enabled flag for all filters #639

dblock opened this issue Jul 6, 2018 · 4 comments

Comments

@dblock
Copy link
Collaborator

dblock commented Jul 6, 2018

See #638 (comment)

Allow all filters to be disabled with enabled='false'.

Deprecate the disableSSO option that shipped in 1.9.1 via #636.

@pedroneil
Copy link
Contributor

Is the enable=false for all filters including Spring and Apache Shiro etc or is this also for a Filter Provider?
e.g. the NegotiateFilterProvider would support NTLM if it is enabled, or will it be easy and stay at Filter level?

@dblock
Copy link
Collaborator Author

dblock commented Jul 7, 2018

I mean it should be possible to do it for each individual filter, but the implementation should be shared.

@hazendaz
Copy link
Member

hazendaz commented Jan 9, 2020

@dblock What was your originally thinking on why to switch "Naming wise, I would change disableSSO to enabled"? I got away on other things back in 2018 when that was originally added. It was only recently I started to use some of the newer logic, not this flag exactly but the abiilty for this to always run on windows and for a vintela filter to run on linux. In my case I made both live. That part seemed a bit contensious as well at the time but for cross platform it works beautifully now. So I think based on tickets I'm seeing that there was a left over concern to switch 'disableSSO' to 'enabled'. I do agree that reads better but give the going on 2 year gap I'm not sure if that still makes sense to really do or not. I also have no real insight into how many are actually using the parameter that was added. What I do know is that vintela I if I recall came with a very similar option in naming around disableVsj or something to that effect.

@dblock
Copy link
Collaborator Author

dblock commented Jan 9, 2020

Yes, I only was commenting on the naming.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants