New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use jna to determine OS type #637

Open

hazendaz opened this issue Jul 4, 2018 · 1 comment

Member

hazendaz commented Jul 4, 2018

Since #636 uses a system environment variable to find windows which could potentially be manipulated, use jna instead as pointed out by @dblock

This seems hacky at best ;) Since waffle uses [JNA] (https://github.com/java-native-access/jna/blob/master/src/com/sun/jna/Platform.java#L137).

Collaborator

dblock commented Jul 4, 2018 •

edited

Loading

The code to change is here: https://github.com/Waffle/waffle/pull/636/files#diff-0307661bd1fa164c209546fa06ec2b48R542.

If I read https://dzone.com/articles/how-to-change-environment-variables-in-java correctly other filters can modify these at runtime, sounds like an additional security risk.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment