Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests for group 'Everyone' not portable when locale isn't English #534

Open
michael-o opened this issue Jun 7, 2017 · 3 comments
Open

Comments

@michael-o
Copy link

michael-o commented Jun 7, 2017

My Windows locale is de_DE and I see this test failure:

[ERROR] Failures:
[ERROR]   NegotiateAuthenticatorTests.testNegotiate:200
[INFO]
[ERROR] Tests run: 27, Failures: 1, Errors: 0, Skipped: 0

The reason is this snippet:

Assert.assertTrue(windowsPrincipal.getGroups().containsKey("Everyone"));

It assumes that the group name is always English which is not case. Ideally, the test would rely on SID only in such cases on have it transformed from SID to well-known local name.

@hazendaz
Copy link
Member

Certainly if you can figure out a better way to test the same, I say go for it and submit a PR.

@michael-o
Copy link
Author

Can you convert from SID to localized string with Waffle? If so, one could take the well-known SID and have to translated by the Windows API for us.

@hazendaz
Copy link
Member

@michael-o I'll look into this issue as well. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants