-
Notifications
You must be signed in to change notification settings - Fork 185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tests for group 'Everyone' not portable when locale isn't English #534
Comments
Certainly if you can figure out a better way to test the same, I say go for it and submit a PR. |
Can you convert from SID to localized string with Waffle? If so, one could take the well-known SID and have to translated by the Windows API for us. |
@michael-o I'll look into this issue as well. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
My Windows locale is
de_DE
and I see this test failure:The reason is this snippet:
It assumes that the group name is always English which is not case. Ideally, the test would rely on SID only in such cases on have it transformed from SID to well-known local name.
The text was updated successfully, but these errors were encountered: