-
Notifications
You must be signed in to change notification settings - Fork 185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Two test failures in NegotiateSecurityFilterTests #533
Comments
@michael-o For me these have always worked. I'm not on a domain on my home machine so I'm sure that has something to do with it. I haven't seen others with issues so I suspect this maybe a rare case. What I can say is that neither travis ci or appvoyer even run tests due to other issues. So if you have time and can write some better tests that still cover the necessary items, I would say go for it and I can merge it in. |
@hazendaz Do you have a chance to test this in a domain? I highly suspect that this is the case. |
@michael-o Yes I can try this later this week. |
@michael-o Sorry for delay. I'm unable to test on a machine with a domain due to some restrictive policies. When I get some more time I'll try turning tests back on for appvoyer and hopefully can flush out these issues there. |
@hazendaz Sure thing, don't hurry. I am busy myself. I'll see wether I can reproduce this with a new Samba version on a Windows 7 joined machine. |
mvn test
tells me:Debugging the test in Eclipse tells me that this code block is used:
so there are always three
WWW-Authenticate
values:Negotiate
,NTLM
,Basic realm="..."
Turning both values to 3 gives me:
The reason for this subsequent failures is
Assert.assertTrue(wwwAuthenticates[0].startsWith("NTLM "));
the index is incorrecteven turning that assertion off gives me:
In case of NTLM,
close
makes absolutely no sense here.My machine (Windows 7 Enterprise) is part of a forest. Just created a Windows 10 Pro VM in VirtualBox which is not joined with any domain. The test passes. So these tests don't seem to be portable for me. Are they?
The text was updated successfully, but these errors were encountered: