-
Notifications
You must be signed in to change notification settings - Fork 186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
waffle-1.7-SNAPSHOT available #130
Comments
Probably holding off for a couple of more weeks before 1.7 release. There are a few things I want to do before this goes out. In the meantime, anyone could pull the above waffle jars and try this release out.
If you don't see any real need to wait on any of this, I can at least pull back on my commit of coverall and get everything else on a pull request tomorrow then start the process of release. Let me know! |
I think you're doing all these great things and should be the one to decide what you want to do with it! |
Thanks. I'm thinking will probably go ahead and move forward as some of the things I wanted to do here don't seem to have any good workaround so some partial items on the current pull request. Now the latest pull request with coverity_scan on it seemed to cause skip in processing so latest build is sort of funny. So I went ahead and added the branch on dblock/waffle. So next run should start to do what I see on mine and essentially that is oracle jdk8 will start failing due to invalid javadocs. That said, I'll start working on those and get building again properly on my end. Then preceding pull request should again do the correct thing and we should be back to green against what is expected. I plan to also fix the remaining coverity items. If all this goes well and looks good on the dblock/master aside from other underlying issues I'm aware of with these extra checkers, probably will promote. So maybe about another week to promote 1.7 after all this is figured out, then immediate start on 1.8. 1.8 onwards -> Then will seriously approach removing any no longer supported third parties (ie spring2, tomcat 5, and the items deprecated (base64). The later of which I decided to just leave deprecated in 1.7 because I've been known in the past to leverage such things if libraries have them available since the legacy sun way for base64 was not to be used and this worked. So I think some did probably use it and 1.7 with deprecation will show our intent to remove and 1.8 will have that removed. I have a lot of ideas for 1.8 which a major one being potential drop of java 6 and servlet 2.5 support. If that sounds good, after branch cleanup, it makes sense to make 1.7 as is a branch so that we can support that for some time due to removing larger scale items in case of any bugs users might find that need addressed. Possibly with the idea that 1.7.x will be last for jdk6 / servlet 2.5. and we will maintain that for a period of time. More and more third parties are starting to do the same here so that makes sense. Plus for deprecated / removed tomcat 5 and spring 2, it gives some additional support there if needed. |
👍 on deprecating unsupported platforms. |
jdk8 issue now resolved. 2 additional items on coverity scan cleared but one gained for same area of code. Basically the majority of what are left are potential but not likely null pointers. All but two are in unit tests. I'll try to clear out the main source code ones in the next day or so. Getting closer and exciting to see all the scans / ci builds occurring. |
Snapshot link added to README, closing this as it is easier now for people to find the snapshots. |
Check out the snapshot and let me know if this looks ready for official release.
https://oss.sonatype.org/content/repositories/snapshots/com/github/dblock/waffle/
The text was updated successfully, but these errors were encountered: