Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Any way to specify an icon for the feed? Either via the favicon or overriding it with a URL? #6

Open
jonathanlaniado opened this issue Jun 4, 2022 · 5 comments

Comments

@jonathanlaniado
Copy link

No description provided.

@Vinnl
Copy link
Owner

Vinnl commented Jun 5, 2022

Hi @jonathanlaniado, Feed me up, Scotty! will currently try to automatically detect the favicon that a website uses for its regular site. However, I think you may be asking about an icon for the combined feed (at /all.xml)? Unfortunately, that's currently not possible, but I've logged the request here: https://gitlab.com/vincenttunru/feed-me-up-scotty/-/issues/11

@jonathanlaniado
Copy link
Author

Ah, no, not the all feed. For example, I have a feed that pulls in correctly from this URL: https://www.raycast.com/store. The website clearly has a favicon and other scripts that generate feeds are pulling in the icon.

I love the elegance of Feed me up, Scotty! though. Any idea why the icon isn't pulling in properly?

@Vinnl
Copy link
Owner

Vinnl commented Jun 5, 2022

@jonathanlaniado Hmm no, not sure; it adds it correctly when I try it. Could you share your config, and a link to the generated feed?

@jonathanlaniado
Copy link
Author

Strange, I tried the feed with Feedbin, Reeder, and NetNewsWire. All returned an empty favicon.

My config is:

[raycaststore]
title = "Raycast Store"
url = "https://www.raycast.com/store"
entrySelector = "div.explore.grid > div"
titleSelector = "div > a"
linkSelector = "div > span > a"
contentSelector = "p"

And the generated feed is: https://jonathanlaniado.github.io/feedmeupscotty/raycaststore.xml.

The strange thing is I see the favicon URL in both the JSON and XML files, but my RSS reader apps aren't picking them up.

@Vinnl
Copy link
Owner

Vinnl commented Jun 6, 2022

Hmm, that is weird. Unfortunately I don't have any leads then - as far as I can see Feed me up, Scotty! is generating the feed correctly and adding the right icon. An error in all those feed readers seems unlikely too, though, but unless someone can point out an error in the generated feed, I'm not sure what it's doing wrong :/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants