Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FuturesPartialDepth #519

Open
hdmark opened this issue Dec 1, 2021 · 2 comments
Open

FuturesPartialDepth #519

hdmark opened this issue Dec 1, 2021 · 2 comments
Labels

Comments

@hdmark
Copy link

hdmark commented Dec 1, 2021

Great project btw!

In the index.d.ts , futuresPartialDepth takes in a depth: PartialDepth in the callback, but then it returns something different.
I changed it and it seemed to work for me :

 futuresPartialDepth: (
      options: { symbol: string; level: number } | { symbol: string; level: number }[],
      callback: (depth: FuturesPartialDepth) => void,
      transform?: boolean,
    ) => ReconnectingWebSocketHandler

and added

  export interface FuturesPartialDepth {
    level: number,
    eventType: string,
    eventTime:  number,
    transactionTime: number,
    symbol: string,
    firstUpdateId: number,
    finalUpdateId: number,
    prevFinalUpdateId: number,
    bidDepth:  BidDepth[],
    askDepth:  BidDepth[],
  }
@balthazar
Copy link
Member

maybe @bennycode has a comment?

@bennycode
Copy link
Contributor

@hdmark can you turn your changes into a PR so it is easier for me to verify your changes?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants