Replies: 30 comments
-
Oh thank you! I really like these!
I like the new application icon as well. I also like the current icon but with the amount of UI changes we are performing we need to reflect this in the app icon somehow so a new icon would be perfect. @barijaona @Eitot what are your thoughts? @Eitot these would integrate with your toolbar ideas wouldn't they? |
Beta Was this translation helpful? Give feedback.
-
This would fit indeed perfectly with my ideas too. I am currently rewriting the plug-in manager so that it takes advantage of NSSharingService. I am not sure about putting them into the share button though. Putting them into that button will probably change the workflow of some users. Moreover, the menu is not really meant for dropping as many custom services into it as Vienna currently has plug-ins, because the user might have set their own preferences in System Preferences → Extensions. We don’t have much control over how to menu is arranged, so all Vienna services would just be stacked at the top of the menu. We would need some kind of interface so that users can manage and rearrange them. Though I would not mind keeping the separate toolbar icons as well (we don’t have to show them in the default toolbar). @Aoiike, thanks for the icons! Have you tested them on Mavericks too? I think they might need a wee bit of tweaking to make them less blurry on non-high-resolution displays. The rubbish bin is perhaps too detailed; it looks a bit ‘heavy’. As for the application icon, I prefer the current one. Apple has chosen to leave some richness in their icons rather than going all flat. Having this tilted, thick icon fits a bit better, in my opinion. |
Beta Was this translation helpful? Give feedback.
-
They are optimized for 1x scale, and this is how they look in Mavericks style. |
Beta Was this translation helpful? Give feedback.
-
They look great 👍 but I'd like to hear @barijaona's thoughts as well. |
Beta Was this translation helpful? Give feedback.
-
I like all these icons, but like Eitot, I‘d prefer a tilted app icon (seems more Mac like to me). |
Beta Was this translation helpful? Give feedback.
-
@Aoiike
Thank you for doing this! |
Beta Was this translation helpful? Give feedback.
-
So according to https://developer.apple.com/library/content/documentation/UserExperience/Conceptual/OSXHIGuidelines/ToolbarIcons.html#//apple_ref/doc/uid/20000957-CH89-SW1 the template images should be:
19 x 19 seems a little small so I'm assuming thats 38x38 @2x etc .. which still seems small but anyway. if we follow those guidelines then macOS should size them correctly for the toolbar control. The only one that looks like it may be a little too large for me is the new subscription icon. @JanX2 The filter icon might look a little bit high because of the anti-aliasing on the bottom of it? Anyway I love the icons @Aoiike and I can't wait to have them in Vienna! |
Beta Was this translation helpful? Give feedback.
-
That probably hasn’t been updated and should say “points”. ;) BTW: the filter icon is a case of not being “visually centered” as per the docs. |
Beta Was this translation helpful? Give feedback.
-
Keep in mind that we have not made up our minds on how the toolbar is going to look in the near future. For instance, there were some suggestions for a combined search field, so we might not need a toolbar icon for the filter. I have also seen a request for a ‘mark as read’/‘mark all as read’ toolbar item. We currently also have ‘Style’ and ‘Get Info’ toolbar items. We would also be needing some template icons for the sidebar eventually, like in Finder or Mail. Specifically icons for: folder, smart folder, feed (for those without a favicon) and trash. |
Beta Was this translation helpful? Give feedback.
-
The HiDPI screenshot is what I hacked together (I'm not good at Xcode), and I haven't figured out alignment yet, so everything including the buttons themselves are misaligned. @JanX2 I did consider the whitespace and dimensions of the Icons while I was making them, and I opted for clarity of purpose over fitting the size guideline. Now that I've been looking at them for a while they look totally fine, so maybe see how they feel after a week or so. The Arrows are intended to look noticeably distinct from the Skip button. @josh64x2 Regarding the 19x19 limit, it doesn't explain why this specific number, especially the use of an odd number in the vertical for icons designed to fit in a 22pt button, so I am assuming this guideline is either outdated or optional. I've also been working to a 26x18 guide, so most of the Icons are wider than 19pt. @Eitot Folders, Smart Folders, Trash, and Get Info all have System Icons which makes things easier. |
Beta Was this translation helpful? Give feedback.
-
They still have to be drawn though, there are no such template images in the APIs. |
Beta Was this translation helpful? Give feedback.
-
Can you load them in from /System/Library/CoreServices/CoreTypes.bundle/Resources, or did SIP break that? |
Beta Was this translation helpful? Give feedback.
-
I do not think so, but it is not a good idea. The paths could change in future macOS versions and as far as I know, we are aiming for sandboxing one day. Best to bundle our own resources or use documented Cocoa APIs. |
Beta Was this translation helpful? Give feedback.
-
Okay, I'll add those to the list. |
Beta Was this translation helpful? Give feedback.
-
In case you haven’t seen it, Apple has guidelines for those icons too: https://developer.apple.com/library/content/documentation/UserExperience/Conceptual/OSXHIGuidelines/SidebarIcons.html. |
Beta Was this translation helpful? Give feedback.
-
@Aoiike You can break with the guidelines, of course. The issue I described comes in part from the variation in whitespace across the icons. :) |
Beta Was this translation helpful? Give feedback.
-
Here is a list of the system provided images we can use for controls https://developer.apple.com/library/content/documentation/UserExperience/Conceptual/OSXHIGuidelines/SystemProvided.html#//apple_ref/doc/uid/20000957-CH92-SW3 And here is the list of icons (including a smart folder icon) https://developer.apple.com/library/content/documentation/UserExperience/Conceptual/OSXHIGuidelines/SystemProvided.html#//apple_ref/doc/uid/20000957-CH92-SW8 |
Beta Was this translation helpful? Give feedback.
-
Unfortunately, we cannot use those folder icons. Apple provides no templates for the sidebar. 😒 |
Beta Was this translation helpful? Give feedback.
-
We should probably make a list of the actual icons 😄 edit: Toolbar templates
|
Beta Was this translation helpful? Give feedback.
-
Hey @Aoiike do you need any help with this? 😄 |
Beta Was this translation helpful? Give feedback.
-
Beta Was this translation helpful? Give feedback.
-
Thank you so much :) |
Beta Was this translation helpful? Give feedback.
-
How does this look when the article list is on the left side rather than at the top? |
Beta Was this translation helpful? Give feedback.
-
I also remembered what I didn't mention, the Sidebar's Search is hidden in the overscroll like in Safari and Notification Center. |
Beta Was this translation helpful? Give feedback.
-
Putting the search box into an overflow area is not really doable with the components that Apple provides. I’ve looked at this weeks ago and I noticed that it cannot be done without some IMO nasty workarounds and it probably would not be very elegant. The fact that we still support Mavericks makes things more difficult. This is a lot easier on iOS where UISearchController provides for this functionality. I am also not sure about making the filter bar a persistent element. I would actually like to merge this functionality into the main search box and move the filter button to the toolbar as well (like your first proposal). |
Beta Was this translation helpful? Give feedback.
-
@Aoiike: I have managed to separate the toolbar. It should be easy now to use the default NSButton look with template images. Would you be willing to submit the toolbar icons? |
Beta Was this translation helpful? Give feedback.
-
Beta Was this translation helpful? Give feedback.
-
I saw that you were looking for some new Icons, so I made these and adjusted the layout slightly
![preview](https://cloud.githubusercontent.com/assets/26124815/23495367/3a93040e-ff10-11e6-8a3b-6641cd106f76.png)
This is just a heavily modified screenshot as a preview.
My Thought Process:
Most of the Icons Vienna currently uses are for sharing the current article on various services, which would make a lot more sense to all be consolidated into a system Share button introduced in 10.8.
The titlebar only seems to show the unread count, which is a bit of a waste on 10.10+, I don't know if it can be set this way and still function on Mavericks, I think there is a fallback function somewhere.
I added a SegmentedControl for the View modes because it's a really useful option that I didn't realize was available until I was going through all the menus.
The Icons themselves are PDFs for template images, mainly to get the native styling on any version of macOS/OS X as recommended by Apple Guidelines, it would also save some time next time they revamp the UI.
I also redid the main Application Icon
![iconpreview](https://cloud.githubusercontent.com/assets/26124815/23496001/8beb439a-ff13-11e6-88aa-71ba5919f8fb.png)
It's different, but I really like it.
Beta Was this translation helpful? Give feedback.
All reactions