Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Birthday] Add pagination for more than 25 entries for "upcoming" #129

Closed
ajwsert opened this issue Feb 23, 2024 · 1 comment
Closed

[Birthday] Add pagination for more than 25 entries for "upcoming" #129

ajwsert opened this issue Feb 23, 2024 · 1 comment
Labels
cog: birthday type: bug Something isn't working

Comments

@ajwsert
Copy link

ajwsert commented Feb 23, 2024

What cog is this feature request for?

Birthday

Describe the feature request in as much detail as possible

Initially, for the upcoming command, when there was more than 25 entries (days) the cog would show only 25 entries with a notice saying it did so. I know it's due embed field limitation.
However, with the latest update something broke. It started to throwing an error in those cases, apparently due attempting to create an embed with more fields than allowed:

Command 'upcoming' raised an exception: HTTPException: 400 Bad Request (error code: 50035): Invalid Form Body
In data.embeds.0.fields: Must be 25 or fewer in length.

My suggestion is about adding some type of pagination that I believe would be helpful. It would either prevent hitting that limit as allowing to view everything instead being limited to the first 25 as it was initially.

@ajwsert ajwsert added the type: enhancement New feature or request label Feb 23, 2024
@ajwsert ajwsert changed the title Add pagination for more than 25 entries. [Birthday] Add pagination for more than 25 entries for "upcoming" Feb 23, 2024
@Vexed01 Vexed01 added cog: birthday type: bug Something isn't working type: enhancement New feature or request and removed type: enhancement New feature or request labels Feb 26, 2024
@Vexed01
Copy link
Owner

Vexed01 commented Mar 16, 2024

Thanks for reporting. It looks like I tried to handle this but missed quite an important line to remove the excess birthdays!

Pagination may come when I have more time. You or anyone else are welcome to submit a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cog: birthday type: bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants