Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conditional statement with identical lines in each branch. #3047

Open
malortie opened this issue Feb 17, 2021 · 1 comment
Open

Conditional statement with identical lines in each branch. #3047

malortie opened this issue Feb 17, 2021 · 1 comment

Comments

@malortie
Copy link

In ev_hldm.cpp, in EV_FireMP5, the following code has identical lines in each branch.

halflife/cl_dll/ev_hldm.cpp

Lines 708 to 715 in c7240b9

if ( gEngfuncs.GetMaxClients() > 1 )
{
EV_HLDM_FireBullets( idx, forward, right, up, 1, vecSrc, vecAiming, 8192, BULLET_PLAYER_MP5, 2, &tracerCount[idx-1], args->fparam1, args->fparam2 );
}
else
{
EV_HLDM_FireBullets( idx, forward, right, up, 1, vecSrc, vecAiming, 8192, BULLET_PLAYER_MP5, 2, &tracerCount[idx-1], args->fparam1, args->fparam2 );
}

It should only use one line.

@malortie
Copy link
Author

@kisak-valve Please, could you change the label to Half-Life or remove the label Deathmatch Classic ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants