Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use GRS for the units #66

Closed
VEZY opened this issue Jun 11, 2024 · 1 comment
Closed

Use GRS for the units #66

VEZY opened this issue Jun 11, 2024 · 1 comment

Comments

@VEZY
Copy link
Owner

VEZY commented Jun 11, 2024

The units for the coordinates are set to meters by default. When we write to the OPF files, we convert into centimeters (yes that's bad but it is what it is). Atm we x100 the values, but we should really transform into cm using the newly implemented CRS in Meshes. The code to update is here:

if row.pos !== Meshes.Point3(0.0, 0.0, 0.0)
pos = Meshes.coordinates(row.pos) .* 100.0 # x100.0 because the scene is in m and the OPF in cm.
scene_transformation = scene_transformation Translate(pos...)
end

Also in:

p_0 = scene_dimensions[1].coords .* 100 # m (scene) to cm (OPF)
p_max = scene_dimensions[2].coords .* 100

What we should do also is to convert from m into cm when writing the OPF, and convert in m from cm when reading the OPF.

@VEZY
Copy link
Owner Author

VEZY commented Jun 13, 2024

Fixed in #69

@VEZY VEZY closed this as completed Jun 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant