Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consistency in mask constants #797

Open
snreynolds opened this issue Jul 16, 2024 · 1 comment
Open

consistency in mask constants #797

snreynolds opened this issue Jul 16, 2024 · 1 comment
Labels

Comments

@snreynolds
Copy link
Member

Component

General design optimization (improving efficiency, cleanliness, or developer experience)

Describe the suggested feature and problem it solves.

In many places we use uint160/uint24 masks. In slot0.sol we define them as constants, but everywhere else we just inline them. I think we should just make it consistent wherever we are masking

Describe the desired implementation.

No response

Describe alternatives.

No response

Additional context.

No response

Copy link

linear bot commented Jul 16, 2024

PROTO-322 consistency in mask constants

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant