Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better test coverage for ERC6909 code path #428

Open
zhongeric opened this issue Nov 27, 2023 · 0 comments
Open

Better test coverage for ERC6909 code path #428

zhongeric opened this issue Nov 27, 2023 · 0 comments
Labels

Comments

@zhongeric
Copy link
Contributor

zhongeric commented Nov 27, 2023

Component

Tests

Describe the suggested feature and problem it solves.

Right now we pass a parameter TestSettings into PoolManager tests to determine whether or not the we call take/settle or mint/burn during a swap. There are only two tests currently in PoolManager.t.sol which check the results of the mint/burn code path.

Describe the desired implementation.

Explore fuzzing of the TestSettings with conditional assertions or potentially remove the TestSettings logic and split out the PoolSwapRouter into PoolERC6909Router and PoolERC20Router, each of which inherit from PoolTestBase

Describe alternatives.

No response

Additional context.

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants