Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Uniswap Interface decentralized IPFS pin #1339

Closed
badkk opened this issue Mar 19, 2021 · 3 comments · Fixed by #1342
Closed

[CI] Uniswap Interface decentralized IPFS pin #1339

badkk opened this issue Mar 19, 2021 · 3 comments · Fixed by #1342
Labels
improvement Improves the ux

Comments

@badkk
Copy link
Contributor

badkk commented Mar 19, 2021

Is your feature request related to a problem? Please describe.

Encouraged by https://uniswap.org/blog/ipfs-uniswap-interface/, we would like to contribute and provide a decentralized IPFS pin solution for Uniswap Interface, to further increase the availability and decentralization.

Describe the solution you'd like

We have built a standard Github Workflow to pin a website to Crust Network in a decentralized way: https://github.com/crustio/ipfs-crust-pinner. And specifically for Uniswap Interface, we have created a workflow to pin it: https://github.com/crustio/ipfs-crust-pinner/actions/workflows/uniswap-interface.yml.

We suggest a code change after https://github.com/Uniswap/uniswap-interface/blob/main/.github/workflows/release.yaml#L48-L55, to include ipfs-crust-pinner action. It will distribute Uniswap Interface over Crust Network and get 50+ IPFS replicas. We can help prepare a code PR to do it.

Crust Network (https://crust.network/) is a decentralized storage network based on IPFS and Substrate, and it basically provides decentralized IPFS Pin service. Right now Crust is running preview network Maxwell and got 1000+ nodes joined in to provide IPFS storage (https://telemetry.polkadot.io/#list/Crust%20Maxwell). Crust is open source(https://github.com/crustio/crust).

Describe alternatives you've considered

N/A

Additional context

You can contact us at [email protected]. We can help prepare a code PR. The pin service will be free for Uniswap, and you can mail us for necessary seeds to call Crust IPFS Pin service.

@badkk badkk added the improvement Improves the ux label Mar 19, 2021
@MicahZoltu
Copy link
Contributor

Note: if adding external workflows, care should be taken to use an explicit commit hash rather than a branch or version to protect against supply chain attacks.

@badkk
Copy link
Contributor Author

badkk commented Mar 19, 2021

Note: if adding external workflows, care should be taken to use an explicit commit hash rather than a branch or version to protect against supply chain attacks.

Sure, we can use the commit id - 8a7788a9c8e18a752264beb988733994187a1d69.

@moodysalem
Copy link
Contributor

I noticed that instead of a hash you pointed to v1.0.8, but I think the risk is minimal given the build is already done and pinned by that step, so it's not possible to introduce a vulnerability into the deployed application at that point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improves the ux
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants