-
Notifications
You must be signed in to change notification settings - Fork 179
HdfEos handling of featureType attribute #932
Comments
I think you've interpreted the question marks correctly - it's much worse to see: // LOOK - WTF?!? which generally means the author didn't know why or could not remember why that line was needed or what it was trying to do. I think your code looks reasonable to me (I'd change the Speaking of tests...would you happen to have some small files that exercise this? Thanks @msdsoftware! |
@lesserwhirls, The change is only implemented in my local copy of thredds-master. I'll make the changes to my fork on Github later today. Will include some comments about other featureTypes being not yet implemented, e.g., also check for a vertical axis so that one can be more sure it's really a profile, or perhaps a trajectoryProfile. |
@lesserwhirls, I submitted a pull request, but if you want to run tests first then you can go to my fork. A sample file (280kB) which ought to labeled with featureType="TRAJECTORY" is at https://www.dropbox.com/s/3tf70xd1kso2y1c/OMSO2_2010m0116t1909-o29293_v003-2014m0924t104451vector.he5?dl=0 |
I have a couple sample HDF-EOS files containing what is essentially featureType trajectory data. However, netCDF-Java is adding a
:featureType = "PROFILE"
global attribute to the files. Poking around in the code, I find that this comes from theHdfEos
class examining the geolocation info, finding that the lat and lon axes are not 2D and defaulting to PROFILE:Note the double question mark in the comment. It would seem that when this was written, someone wasn't entirely sure that they were doing the right thing?
I'm looking at fixing this by having the geolocation examination also look for a time axes, and then replacing the above with
This solution isn't perfect — certainly it omits the possibility of other featureTypes — but it should be an improvement over what's in
HdfEos
now.Any comments, thoughts, criticism?
The text was updated successfully, but these errors were encountered: