Skip to content
This repository has been archived by the owner on Sep 1, 2022. It is now read-only.

Review RAF usage in IOSPs. #575

Open
JohnLCaron opened this issue Jun 25, 2016 · 0 comments
Open

Review RAF usage in IOSPs. #575

JohnLCaron opened this issue Jun 25, 2016 · 0 comments

Comments

@JohnLCaron
Copy link
Collaborator

JohnLCaron commented Jun 25, 2016

Best practice for IOSP is to allow AbstractIOSP to handle the RandomAccessFile. Complex IOSPs often store a pointer to the raf. For efficiency, the NetcdfFile/IOSP is cached seperate from the RAF. When the RAF is closed/reopened on a cached IOSP, then we get a stale handle, typically a NPE when trying to read data.

Review of all IOSPs that cache RAFs:

  • Cinrad2IOServiceProvider has same problems that were fixed in Nexrad2.
  • GradsBinaryGridServiceProvider has problems - not currently being used.
  • Ghcnm, Ghcnm2, IgraPor may have issues because they are managing 2 rafs. These are also using StructureDataRegexp which cache the raf
  • All IOSPs in visad module (gempak, mcidas, vis5d) cache the raf and may have issues. Should decide if these are worth tweaking, rewriting, or abandoning.

Pull request to fix definite problems in:

  • H5iosp

Pull requests to fix possible problems in:
-H4iosp
-N3iosp
-Nidsiosp
-NOWRadiosp

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant